Skip to content

inputmodule-control: init at 0.2.0-unstable-2024-11-17#357581

Closed
dsluijk wants to merge 2 commits intoNixOS:masterfrom
dsluijk:inputmodule-control
Closed

inputmodule-control: init at 0.2.0-unstable-2024-11-17#357581
dsluijk wants to merge 2 commits intoNixOS:masterfrom
dsluijk:inputmodule-control

Conversation

@dsluijk
Copy link
Member

@dsluijk dsluijk commented Nov 20, 2024

This adds the inputmodule-control program for the Framework 16's LED Matrix module. I also added a module in hardware for the framework which sets the udev rules correctly. This is scoped under the (otherwise empty) framework option for futureproofing. Tested locally to make sure it actually works. Uses the unstable version from the main branch as the last release is almost a year old.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dsluijk dsluijk force-pushed the inputmodule-control branch from 43a4d54 to ee0da03 Compare November 20, 2024 15:39
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Nov 20, 2024
@dsluijk dsluijk force-pushed the inputmodule-control branch from ee0da03 to 634b87d Compare November 20, 2024 15:50
@dsluijk dsluijk force-pushed the inputmodule-control branch from 634b87d to f9b427f Compare November 20, 2024 15:50
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Nov 20, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 21, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Nov 27, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 2, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@wolfgangwalther
Copy link
Contributor

Done in #307293.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: hardware Drivers, Firmware and Kernels 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants