inputmodule: init inputmodule-control (pkg), init inputmodule (module)

[Kitt3120]

Description of changes

This adds support for Framework input modules, like the LED matrix module.

I added an inputmodule-control pkg which builds the binary of the official CLI tool by Framework. It also provides udev rules when added to the list of udev packages, which allow for rootless access to input modules. The udev rules are also provided by Framework. It's fetched from GitHub using fetchFromGitHub and builds using buildRustPackage.

I additionally added a NixOS module that adds the option hardware.inputmodule.enable. Setting it to true adds inputmodule-control pkg to config.environment.systemPackages and config.services.udev.packages.

Repo: https://github.com/FrameworkComputer/inputmodule-rs

Release: https://github.com/FrameworkComputer/inputmodule-rs/releases/tag/v0.2.0

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Kitt3120]

My vs code formatted the release notes file differently. Will fix this.

[Kitt3120]

Fixed :)

[Kitt3120]

Can anyone help me on the ofborg-eval check? I don't really get why it fails.

… while evaluating the attribute 'cargoDeps' of the derivation 'inputmodule-control-0.2.0'

Edit: Seems like I fixed it. I had to include the Cargo.lock file and reference it locally. Previously, I referenced it by ${src}/Cargo.lock, which worked locally but apparently caused problems with ofborg's check.

[Kitt3120]

Hey @Aleksanaa, I've seen your name show up often around here :) Would you mind taking a look at my PR?

Also, I'm new to the nixpkgs repo. Is it okay to ping for reviews? Or would my PR just get picked up soon anyway?

Edit: Okay, have some conflicts with upstream now, will resolve tomorrow.

[Kitt3120]

Rebased the branch and resolved conflicts

Edit: Have exams coming up. Will update this when I have some time again.

Edit 2: Updated again. Changelog moved from 24.05 to 24.11.

[Kitt3120]

Rebased

[Kitt3120]

Thanks for the review! I included your suggestions.

[Kitt3120]

I think ofborg is not a fan of this change. I'll try a rebase.

[FliegendeWurst]

It might have been due to #354738 if it was the lib tests failing (can't see the failure anymore)

[Kitt3120]

It might have been due to #354738 if it was the lib tests failing (can't see the failure anymore)

yes, it was the lib test! Alright, then the rebase should do the trick.