Skip to content

fetch-cargo-vendor: allow retries for 10 times #357258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bot-wxt1221 wants to merge 1 commit into from
Closed

fetch-cargo-vendor: allow retries for 10 times #357258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkgs/build-support/rust/fetch-cargo-vendor-util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,18 @@ def load_toml(path: Path) -> dict[str, Any]:
return tomllib.load(f)


def get_response(url):
for _ in range(10): # Retry if the request fails
try:
response = requests.get(url, stream=True)
Copy link
Member

@Mic92 Mic92 Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some timeout i.e. exponential backoff as well so we are not overloading crates.io with requests in case they are overloaded.

return response
except requests.exceptions.RequestException:
pass


def download_file_with_checksum(url: str, destination_path: Path) -> str:
sha256_hash = hashlib.sha256()
with requests.get(url, stream=True) as response:
with get_response(url) as response:
if not response.ok:
raise Exception(f"Failed to fetch file from {url}. Status code: {response.status_code}")
with open(destination_path, "wb") as file:
Expand Down