fetch-cargo-vendor: allow retries for 10 times#357258
Closed
Bot-wxt1221 wants to merge 1 commit intoNixOS:masterfrom
Closed
fetch-cargo-vendor: allow retries for 10 times#357258Bot-wxt1221 wants to merge 1 commit intoNixOS:masterfrom
Bot-wxt1221 wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: rust
Mic92
reviewed
Nov 19, 2024
| def get_response(url): | ||
| for _ in range(10): # Retry if the request fails | ||
| try: | ||
| response = requests.get(url, stream=True) |
Member
There was a problem hiding this comment.
Please add some timeout i.e. exponential backoff as well so we are not overloading crates.io with requests in case they are overloaded.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #356862
cc #357257
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.