postgresql: update to new minor versions #355965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
Member
|
Looking at it now. |
Contributor
Author
|
Note: There is an ongoing discussion upstream about ABI incompatibilities for the new minor versions, which means that extensions compiled against e.g. 14.13 would potentially not work against 14.14. Of course - this doesn't affect us, because we rebuild all extensions anyway. There is discussion about fixing that by moving things in some structs around and essentially re-doing the release, though. I am watching the discussion here: https://www.postgresql.org/message-id/flat/CABOikdNmVBC1LL6pY26dyxAS2f%2BgLZvTsNt%3D2XbcyG7WxXVBBQ%40mail.gmail.com I think the best course of action right now is to proceed with this as planned - and if upstream decides to do something, then update to whatever they do immediately as well. I don't think we should wait for them. Given the nature of nix, we are prepared for whatever they do - after all the releases are not broken for us at all. Edit: Imho, the direction it took is that there is not going to be any change. |
Contributor
Author
|
Contributor
Author
Those are already broken on master, I think. I saw that a couple of days ago, but haven't been able to figure it out, yet. |
Member
To me
sounds like a patch-release. |
Ma27
added
the
1.severity: security
Contributor
Author
|
Even though there are 574 rebuilds here, I think this should good to go into master, because it's unlikely that anyone uses all postgresql versions and then all extensions, too. So the actual number of rebuilds for anyone tracking master would be much lower. Does that make sense? Or is the number of rebuilds allowed into master limited for a different reason? |
Member
|
Tagging as security-relevant for CVE-2024-10976, CVE-2024-10977, CVE-2024-10978, CVE_2024-10979.
I think it's perfectly reasonable as-is given the kinds of rebuilds. Backporting to 24.05 will require manual action. |
Ma27
added
the
9.needs: port to stable
Contributor
Author
I can prepare that tomorrow evening, if you can't get to it before. |
Ma27
approved these changes
Nov 14, 2024
1 task
Contributor
|
Successfully created backport PR for |
13 tasks
Ma27
removed
the
9.needs: port to stable
Merged
13 tasks
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all postgresql versions except v16 to the new minor released today:
https://www.postgresql.org/about/news/postgresql-171-165-159-1414-1317-and-1221-released-2955/
v16 will cause many more rebuilds, so I will target that at staging: #355974.
@Ma27
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.