Skip to content

python3Packages.pytest-xdist: change pytestFlagsArray in preCheck hook#354791

Merged
emilazy merged 1 commit intoNixOS:stagingfrom
wolfgangwalther:no-python-eval-pytest-xdist
Nov 12, 2024
Merged

python3Packages.pytest-xdist: change pytestFlagsArray in preCheck hook#354791
emilazy merged 1 commit intoNixOS:stagingfrom
wolfgangwalther:no-python-eval-pytest-xdist

Conversation

@wolfgangwalther
Copy link
Contributor

Same as #354785, but for pytest-xdist. This commit causes 50k+ rebuilds on darwin and 40k+ on linux.

@ShamrockLee @emilazy

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 9, 2024
We don't want to depend on bash eval in pytestFlagsArray to be able to
remove it, thus move it to bash code in preCheck.
@wolfgangwalther wolfgangwalther force-pushed the no-python-eval-pytest-xdist branch from 87cde97 to 457241d Compare November 9, 2024 15:19
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Nov 9, 2024
@ofborg ofborg bot requested a review from dotlambda November 9, 2024 22:39
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 9, 2024
@ShamrockLee
Copy link
Contributor

A significant package that indirectly depends on pytest-xdist
@ofborg build python311Packages.numpy python311Packages.numpy.tests python312Packages.numpy python312Packages.numpy.tests

A large package touching a lot of Python packages
@ofborg build python311Packages.tensorflow

@wolfgangwalther
Copy link
Contributor Author

With everything we know about pytestFlagsArray.. this change should be very straight forward to merge just from looking at it.

@emilazy emilazy merged commit 9af710b into NixOS:staging Nov 12, 2024
@wolfgangwalther wolfgangwalther deleted the no-python-eval-pytest-xdist branch November 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants