python3Packages.psutil: use placeholder "out" instead of $out#354785
Merged
emilazy merged 1 commit intoNixOS:stagingfrom Nov 13, 2024
Merged
python3Packages.psutil: use placeholder "out" instead of $out#354785emilazy merged 1 commit intoNixOS:stagingfrom
emilazy merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
Codeowners check failure is unrelated. Seems like staging has the by-name commit already, but not the codeowner commit related to it.. even though they were only 4 minutes apart. That's unlucky! :D |
13 tasks
Member
|
Fixed. Hopefully. Sorry about that. |
wolfgangwalther
force-pushed
the
no-python-eval-psutil
branch
from
6d26948 to
f689d9d
Compare
13 tasks
ofborg
bot
added
10.rebuild-darwin-stdenv
dotlambda
reviewed
Nov 12, 2024
wolfgangwalther
force-pushed
the
no-python-eval-psutil
branch
from
f689d9d to
7474fba
Compare
To avoid depending on bash eval behavior of pytestFlagsArray, which we'd like to remove.
wolfgangwalther
force-pushed
the
no-python-eval-psutil
branch
from
7474fba to
17a4a36
Compare
dotlambda
changed the title
dotlambda
approved these changes
Nov 13, 2024
Contributor
|
@ofborg build python311Packages.psutil python312Packages.psutil |
Contributor
Author
|
The x86_64-darwin ofborg failure is certainly unrelated, because the tests are not even run on darwin. Should be good to go. |
emilazy
approved these changes
Nov 13, 2024
Member
|
This won’t make 24.11, by the way, but I assume that the changes that would break this would only land in 25.05 anyway. |
Contributor
Author
Yeah, absolutely - this is just preparing the mid-term effort of "structuredAttrs by default". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split from #352976. This commit alone causes 50k+ rebuilds on darwin and 35k+ on linux.
I am still investigating the other commits' impact, but this one should be simple to review by just looking at it.
@ShamrockLee @emilazy
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.