Skip to content

Comments

morgen: bump electron version to electron_32#350630

Merged
emilazy merged 1 commit intoNixOS:masterfrom
NotAShelf:bump-morgen
Nov 5, 2024
Merged

morgen: bump electron version to electron_32#350630
emilazy merged 1 commit intoNixOS:masterfrom
NotAShelf:bump-morgen

Conversation

@NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Oct 23, 2024

  • morgen: bump electron version to electron_32

Bump Electron version of morgen from Electron 30 to Electron 32. Tested, but the app never launches for me - not with E30, nor with E32. Likely cause is Wayland, but unsure.

See: #350549

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 23, 2024
@emilazy
Copy link
Member

emilazy commented Oct 27, 2024

cc @justanotherariel

Copy link
Contributor

@justanotherariel justanotherariel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justanotherariel
Copy link
Contributor

Weird that it doesn't work for you... I'm not using wayland anymore though, so that is possible. I just know for a fact that it worked in the past. If it still is relevant, you could can open another issue with the logs / error messages by running morgen from the terminal.

@justanotherariel justanotherariel added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 5, 2024
@emilazy emilazy merged commit f68a3b9 into NixOS:master Nov 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants