mjmap: init at 0.1.0-unstable-2023-11-13#346977
Conversation
I needed to use `git send-email`, and I wanted an MTA that supported JMAP to use with it. We already package `mujmap`, but even after bumping it to the latest Git commit to deal with Fastmail authentication changes, it choked on the beautiful UTF‐8 email I created. Enter this random Go tool from a random SourceHut repository that did just the trick.
emilazy
force-pushed
the
push-luwozrzttzlk
branch
from
630fbb3 to
7779a7b
Compare
ofborg
bot
added
8.has: package (new)
| installCheckPhase = '' | ||
| runHook preInstallCheck | ||
|
|
||
| $out/bin/mjmap --version >/dev/null | ||
|
|
||
| runHook postInstallCheck | ||
| ''; |
There was a problem hiding this comment.
Perhaps this is best expressed through a versionCheckHook or passthru.tests.version = testVersion?
There was a problem hiding this comment.
Nope, because it reports its version as 0.0.0 🫠
There was a problem hiding this comment.
I could add an explanatory comment, though.
| description = "Sendmail‐compatible JMAP client"; | ||
| homepage = "https://git.sr.ht/~rockorager/mjmap"; | ||
| license = lib.licenses.mpl20; | ||
| sourceProvenance = [ lib.sourceTypes.fromSource ]; |
There was a problem hiding this comment.
Isn't this the default?
There was a problem hiding this comment.
Yes, as is license = lib.licenses.free;. See #329470 (comment), #330741 (comment), and #332035 (comment) for my thoughts on this. Hopefully, in the future, both license and sourceProvenance will be mandatory fields.
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Seems good to me! The explanatory comment for the installCheck seems unnecessary, as you're the sole maintainer and it's quite easy to go from the git blame to the comments on this PR.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 346977
x86_64-linux
✅ 1 package built:
- mjmap
huh! This is the first time I saw nixpkgs-review's bespoke new markdown output.
SigmaSquadron
added
the
12.approvals: 1
3 participants
I needed to use
git send-email, and I wanted an MTA that supported JMAP to use with it. We already packagemujmap, but even after bumping it to the latest Git commit to deal with Fastmail authentication changes, it choked on the beautiful UTF‐8 email I created. Enter this random Go tool from a random SourceHut repository that did just the trick.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.