Skip to content

Comments

python3Packages.nose3: drop#330741

Merged
emilazy merged 9 commits intoNixOS:masterfrom
emilazy:push-rlvumrtyxrmk
Aug 2, 2024
Merged

python3Packages.nose3: drop#330741
emilazy merged 9 commits intoNixOS:masterfrom
emilazy:push-rlvumrtyxrmk

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jul 28, 2024

Description of changes

If nose is so good why isn’t there a nose3?

#326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from natsukium as a code owner July 28, 2024 22:49
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 28, 2024
@emilazy emilazy mentioned this pull request Jul 28, 2024
Closed
SuperSandro2000
SuperSandro2000 reviewed Jul 28, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Jul 28, 2024
View reviewed changes
pkgs/tools/admin/gixy/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source should be not set as otherwise we had a lot of code deduplication

Copy link
Member Author

@emilazy emilazy Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #329470 (comment) for my (and others’) thoughts on that. (If sourceProvenance = [ lib.sourceTypes.fromSource ]; is redundant, so is sourceProvenance = [ lib.sourceTypes.fromSource lib.sourceTypes.binaryNativeCode ]; and arguably even sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];, not to mention license = lib.licenses.free; which nobody would argue for dropping.)

@emilazy emilazy force-pushed the push-rlvumrtyxrmk branch from 6e30c10 to 036cfae Compare July 28, 2024 23:05
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jul 29, 2024
@ofborg ofborg bot requested review from WilliButz and sjagoe July 29, 2024 01:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 29, 2024
@natsukium
Copy link
Member

natsukium commented Jul 29, 2024

Result of nixpkgs-review pr 330741 at 036cfae1 run on x86_64-linux 1

5 packages built successfully:
  • gixy
  • grin
  • nixpkgs-manual
  • svtplay-dl
  • tests.testers.lycheeLinkCheck.network

natsukium
natsukium approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase?

@emilazy emilazy force-pushed the push-rlvumrtyxrmk branch from 036cfae to 15f6dd3 Compare July 31, 2024 18:13
@emilazy
Copy link
Member Author

emilazy commented Jul 31, 2024

Rebased. (I guess I’ll have to rebase #330725 afterwards too…)

@natsukium
Copy link
Member

natsukium commented Aug 1, 2024

Oh, sorry, I merged the #330725 first. I'll rebase.

@emilazy
Copy link
Member Author

emilazy commented Aug 2, 2024

I think we should be good to merge this.

@emilazy emilazy merged commit 8764d89 into NixOS:master Aug 2, 2024
@emilazy emilazy mentioned this pull request Aug 22, 2024
Merged
13 tasks
@emilazy emilazy deleted the push-rlvumrtyxrmk branch August 26, 2024 01:01
@emilazy emilazy mentioned this pull request Oct 14, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@natsukium natsukium natsukium approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

@sjagoe sjagoe Awaiting requested review from sjagoe

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilazy @natsukium @SuperSandro2000