Skip to content

freecad: 0.21.2 → 1.0rc2#343592

Merged
kirillrdy merged 2 commits intoNixOS:masterfrom
srounce:freecad-1.0RC
Sep 30, 2024
Merged

freecad: 0.21.2 → 1.0rc2#343592
kirillrdy merged 2 commits intoNixOS:masterfrom
srounce:freecad-1.0RC

Conversation

@srounce
Copy link
Contributor

@srounce srounce commented Sep 21, 2024

Description of changes

Fixes #341214

Update FreeCAD to latest 1.0 Release Candidate (includes commits for all release candidates). I've had this building for quite some time in srounce/freecad.nix albeit with a slightly different slimmed down derivation. This PR ports the key changes to the existing Nixpkgs version allowing it to build 1.0RC.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@srounce
Copy link
Contributor Author

srounce commented Sep 21, 2024

@GrahamcOfBorg build freecad
@ofborg

@ofborg ofborg bot requested review from AndersonTorres and gebner September 21, 2024 22:51
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 21, 2024
@srounce
Copy link
Contributor Author

srounce commented Sep 21, 2024

@AndersonTorres @gebner I suspect there is some cruft in the derivation that could be removed, as there are many more dependencies than in my freecad.nix flake which contains only what is needed to build plus some optional ones for the features I use. However as I don't use every single feature I'm unsure as to whether some of these dependencies are required by the features that I don't use.

@srounce srounce changed the title freecad: 0.21.2 → 1.0 freecad: 0.21.2 → 1.0 RC Sep 22, 2024
@ksonj ksonj mentioned this pull request Sep 23, 2024
13 tasks
@luzpaz luzpaz mentioned this pull request Sep 24, 2024
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@srounce srounce changed the title freecad: 0.21.2 → 1.0 RC freecad: 0.21.2 → 1.0rc2 Sep 27, 2024
@srounce
Copy link
Contributor Author

srounce commented Sep 27, 2024

@wegank Merge conflict fixed, cheers 👍

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-09-30 07-18-38

@bjornfor
Copy link
Contributor

I don't like that the FreeCAD package in nixpkgs was updated from a stable release to an unstable release candidate. Why couldn't the PR be tested here until the final upstream release was made? Or at least add the "rc" version as an additional low-prio package?

What's the plan for the upcoming NixOS release? Ship a release candidate?

@bjornfor
Copy link
Contributor

FreeCAD is back on a stable release now: #357360 🎉 The release branch is still on 1.0rc2 though.

@kirillrdy
Copy link
Member

@bjornfor 1.0 has been backported to 24.11 #357967

@bjornfor
Copy link
Contributor

@bjornfor 1.0 has been backported to 24.11 #357967

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update request: freecad 0.21.2 → 1.0RC

4 participants