freecad: 0.21.2 → 1.0

[pinpox]

Description of changes

Addresses: #341214

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[pinpox]

@GrahamcOfBorg build freecad
@ofborg

[pinpox]

There is still a build failiure here, which I don't know how to fix yet. Can anyone with more cmake knowledge give me a pointer on what is wrong?

[ksonj]

I'm getting one step further with adding -DINSTALL_TO_SITEPACKAGES=OFF to cmakeFlags. However the build still fails with

Broken paths found in a .pc file! /nix/store/agc18s7zjsy4has50h79k18n16lskdnk-freecad-1.0rc1/share/pkgconfig/OndselSolver.pc
The following lines have issues (specifically '//' in paths).
3:libdir=${exec_prefix}//nix/store/agc18s7zjsy4has50h79k18n16lskdnk-freecad-1.0rc1/lib
4:includedir=${prefix}//nix/store/agc18s7zjsy4has50h79k18n16lskdnk-freecad-1.0rc1/include
It is very likely that paths are being joined improperly.
ex: "${prefix}/@CMAKE_INSTALL_LIBDIR@" should be "@CMAKE_INSTALL_FULL_LIBDIR@"

The message then points to #144170 for further information

[ksonj]

There's also this PR #343592, which builds already

[srounce]

Thanks for the reference @ksonj I forgot to add that here.

[pinpox]

There's also this PR #343592, which builds already

Closing, as this PR was already merged.

[srounce]

@pinpox Is it worth keeping open until 1.0 proper is released?

[srounce]

@pinpox sorry I commented on the wrong tab, thought I was commenting on the packaging request 🤦. I will reopen a new issue when another RC or 1.0 final is released. Feel free to close this one again :)