modrinth-app-unwrapped: refactor and use pnpm hooks#341085
Closed
TomaSajt wants to merge 2 commits intoNixOS:masterfrom
Closed
modrinth-app-unwrapped: refactor and use pnpm hooks#341085TomaSajt wants to merge 2 commits intoNixOS:masterfrom
TomaSajt wants to merge 2 commits intoNixOS:masterfrom
Conversation
getchoo
requested changes
Sep 12, 2024
Member
getchoo
left a comment
There was a problem hiding this comment.
The new pnpm hooks have already been adopted in #336494 along with some other fixes/improvements. Regarding the other refactors here
-
I'm not sure why we would switch to
mkDerivation- The only real benefit is with improved overriding, but I don't think that's worth the cost of us reconstructing parts of
buildRustPackage - It will be mostly moot after #335751, which is meant to work alongside
rustPlatformto easily control build profiles, flags, cross compilation, etc.
- The only real benefit is with improved overriding, but I don't think that's worth the cost of us reconstructing parts of
-
The way bundles are generated is a lot more naive in regards to platform support
- Currently it's much easier to add more platforms in an attrset rather than constantly adding on to an
if .. else ifchain - Will also be moot after #335751
- Currently it's much easier to add more platforms in an attrset rather than constantly adding on to an
Contributor
Author
|
Regarding the other refactors here
Ah, thanks, didn't know about that PR. Great to hear that it exists. |
Contributor
Author
Ah, I forgot to search for existing PR, I should remember to do that more often. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
pnpm_*.configHookwas added some time ago, and this package wasn't yet using it, so I refactored the package to use it.I also simplified the way it's decided which bundle to generate. I can revert this, if needed.
In another commit (that I will merge into the first one, if decided that it's an improvement) I made the package use
mkDerivationcombined withcargoSetupHook, since that's the only functionality that the package was using anyway (because the build phase is overridden).This allowed getting rid of the
recadded in the first commit.Note: the
theseusrepo has been renamed tocodeand combined into a monorepo. I didn't update therepooffetchFromGitHubyet, just wanted to share this.It seems that upstream is only keeping the tag for the latest version of the package in the
coderepo. Might need to ask them to start tagging properly.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.