modrinth-app: 0.7.1 -> 0.8.2#336494
Merged
Aleksanaa merged 5 commits intoNixOS:masterfrom Oct 27, 2024
Merged
Conversation
getchoo
force-pushed
the
pkgs/modrinth-app/0.8.2
branch
from
bedfedf to
d385207
Compare
ofborg
bot
added
11.by: package-maintainer
This was referenced Aug 29, 2024
Member
Author
|
cc @SuperSandro2000 from #318117 (review) |
getchoo
force-pushed
the
pkgs/modrinth-app/0.8.2
branch
from
d385207 to
115f15e
Compare
Member
|
Result of 2 packages built:
|
Scrumplex
added
the
12.approvals: 1
13 tasks
Contributor
|
Bumping this, would love to see it merged. There are new versions since this (we're up to 0.8.7 now), but let's start with this. |
llakala
approved these changes
Sep 19, 2024
wegank
added
12.approvals: 2
getchoo
force-pushed
the
pkgs/modrinth-app/0.8.2
branch
from
115f15e to
f5d538e
Compare
getchoo
removed
the
12.approvals: 2
llakala
suggested changes
Sep 21, 2024
Contributor
llakala
left a comment
llakala
left a comment
There was a problem hiding this comment.
Looks great other than the lib changes. Builds great on my system before and after the changes.
llakala
approved these changes
Sep 22, 2024
getchoo
added
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
Contributor
|
Bumping this, would love to see it merged. |
Member
Author
These will be available after #346277 I'll also fix these merge conflicts when I get the chance |
Scrumplex
reviewed
Oct 20, 2024
Namely the broken recursion structure and meta-attributes in the wrapper
passthru.updateScript is removed to avoid accidental upgrades as upstream now uses a monorepo and hasn't actually tagged anything new yet
getchoo
force-pushed
the
pkgs/modrinth-app/0.8.2
branch
from
f5d538e to
9531d73
Compare
getchoo
removed
the
12.approvals: 1
ofborg
bot
removed
the
2.status: merge conflict
Member
|
Scrumplex
approved these changes
Oct 26, 2024
Member
|
builds and runs. Should be good to go. |
getchoo
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Biggest change is upstream moving to a monorepo with many other packages. Didn't require too many changes thankfully!
This ends up segfaulting on launch with my machine currently though, and I can't seem to figure out why. Testing here would be appreciated to see what exactly is causing this -- I'm on nixos-unstable with NVIDIA driver 555.58.02 for reference. Will try 560 laterNVIDIA driver 555 and 560 seem to be broken here, probably due to a webkit or driver issue. Using NVK allows the app to launch normallyThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.