electron-fiddle: 0.32.6 -> 0.36.4, fix build and refactor

[TomaSajt]

Description of changes

electron_24 has been EOL for a while now, so electron-fiddle was not being built.
In this PR I force @electron/forge to use the latest version of electron for building by directly patching the node_modules directory instead of doing a lot of hashing logic, like previously.

One weird thing is that upon first starting the app, Electron v24 will be selected by default.
That may be because of the old releases.json being used.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[FliegendeWurst]

Build fails

Running phase: configurePhase
no configure script, doing nothing
/build/source/electron-dist /build/source
/build/source
substitute(): ERROR: file 'node_modules/@electron/packager/dist/packager.js' does not exist

[TomaSajt]

Build fails

Running phase: configurePhase
no configure script, doing nothing
/build/source/electron-dist /build/source
/build/source
substitute(): ERROR: file 'node_modules/@electron/packager/dist/packager.js' does not exist

Looks like it broke because of #338093
Should be pretty easy to fix.

[andersk]

Thanks @TomaSajt! I’m updating this (with co-authorship credit) at

• electron-fiddle: 0.32.6 → 0.36.5 #385681

[TomaSajt]

Okay! Thanks for picking it up.