Skip to content

yarnConfigHook: apply as a postConfigure hook#338093

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/yarnConfigHook/postConfigure
Aug 29, 2024
Merged

yarnConfigHook: apply as a postConfigure hook#338093
philiptaron merged 1 commit intoNixOS:masterfrom
getchoo-contrib:pkgs/yarnConfigHook/postConfigure

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Aug 29, 2024

Description of changes

Split off from #335751

This follows in this example of npmConfigHook and allows for using this
hook alongside others that may override configurePhase

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This follows in this example of npmConfigHook and allows for using this
hook alongside others that may override configurePhase
@getchoo getchoo requested a review from philiptaron as a code owner August 29, 2024 03:31
@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Aug 29, 2024
@getchoo getchoo mentioned this pull request Aug 29, 2024
13 tasks
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

Result of nixpkgs-review pr 338093 run on x86_64-linux 1

1 package failed to build:
  • powerdns-admin
18 packages built:
  • auto-changelog
  • coc-diagnostic
  • codefresh
  • diagnostic-languageserver
  • dotenv-cli
  • get-graphql-schema
  • koodo-reader
  • listmonk
  • postlight-parser
  • screego
  • spectral-language-server
  • textlint-rule-prh
  • treedome
  • vim-language-server
  • vimPlugins.coc-diagnostic
  • xplorer
  • yarnConfigHook
  • your_spotify

powerdns-admin is broken on master.

@philiptaron philiptaron merged commit c03c988 into NixOS:master Aug 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 29, 2024
@getchoo getchoo deleted the pkgs/yarnConfigHook/postConfigure branch August 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants