Skip to content

mplayer: unpin FFmpeg 6#337316

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-uvyzotvnqrqy
Aug 25, 2024
Merged

mplayer: unpin FFmpeg 6#337316
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-uvyzotvnqrqy

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 25, 2024

Description of changes

I said “It seems like it will require work for 7” in #331568, but it turns out that they already did that work between when I first made the commit and when I last amended it to bump the revision before pushing it out.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from edolstra August 25, 2024 20:29
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 25, 2024
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@emilazy emilazy merged commit 984109c into NixOS:master Aug 25, 2024
@emilazy emilazy deleted the push-uvyzotvnqrqy branch August 26, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments