mplayer: unstable-2022-02-03 -> 1.5-unstable-2024-07-03#331568
Merged
marcusramberg merged 1 commit intoNixOS:masterfrom Aug 6, 2024
Merged
mplayer: unstable-2022-02-03 -> 1.5-unstable-2024-07-03#331568marcusramberg merged 1 commit intoNixOS:masterfrom
marcusramberg merged 1 commit intoNixOS:masterfrom
Conversation
Includes fixes for FFmpeg 6. It seems like it will require work for 7, though.
ofborg
bot
added
10.rebuild-darwin: 1-10
Mindavi
approved these changes
Aug 2, 2024
Contributor
Mindavi
left a comment
Mindavi
left a comment
There was a problem hiding this comment.
Diff LGTM. Derivation could maybe use some cleanup at some point, but can also be something for later
Member
Author
|
Yeah I’ve been doing a fair bit of clean‐up while going through users of FFmpeg 4 to patch them up but this one is kind of huge and my refactoring would just be |
Contributor
|
Result of 12 packages built:
|
Contributor
|
Also tested that it can still play videos :) |
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes fixes for FFmpeg 6. It seems like it will require work for 7, though.
(Yeah, MPlayer apparently still gets updates! I’m as surprised as you are.)
Result of
nixpkgs-reviewrun on aarch64-linux 110 packages built:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.