mesa: only build with valgrind if available on host platform#337065
Closed
NickCao wants to merge 1 commit intoNixOS:stagingfrom
Closed
mesa: only build with valgrind if available on host platform#337065NickCao wants to merge 1 commit intoNixOS:stagingfrom
NickCao wants to merge 1 commit intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
skeuchel
suggested changes
Aug 28, 2024
skeuchel
left a comment
skeuchel
left a comment
There was a problem hiding this comment.
As detailed in my comment, the (lib.mesonEnable "valgrind" false) part needs fixing. Other than that it LGTM. Will try to build it on riscv64-linux as well.
skeuchel
approved these changes
Aug 29, 2024
skeuchel
left a comment
skeuchel
left a comment
There was a problem hiding this comment.
Now it's a NOOP on the platforms valgrind is available on, so LGTM.
|
As a side note, to get this to build on riscv64-linux I had to disable the |
vcunat
pushed a commit
that referenced
this pull request
Aug 29, 2024
Member
|
Pushed directly to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes the evaluation/build of mesa on riscv and other platforms that valgrind doesn't have support for. And valgrind is an optional dependency by default: https://gitlab.freedesktop.org/mesa/mesa/-/blob/mesa-24.1.6/meson.build?ref_type=tags#L1912
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.