libpsl: don't make first output conditional if build statically#336884
Merged
philiptaron merged 1 commit intoNixOS:stagingfrom Aug 29, 2024
Merged
libpsl: don't make first output conditional if build statically#336884philiptaron merged 1 commit intoNixOS:stagingfrom
philiptaron merged 1 commit intoNixOS:stagingfrom
Conversation
This can cause surprises if no output is chosen.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 501+
Cryolitia
approved these changes
Aug 27, 2024
Member
Cryolitia
left a comment
Cryolitia
left a comment
There was a problem hiding this comment.
I have no idea how to review it but just LGTM
philiptaron
approved these changes
Aug 29, 2024
Contributor
|
Result of 9 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can cause surprises if no output is chosen.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.