libpsl: fix static build (fixes nixStatic)#335458
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Aug 17, 2024
Merged
Conversation
We cannot build python statically, so we cannot have it as a runtime dependency
Mic92
changed the title
Contributor
|
This is probably correct for now, but as mentioned in the other issue we should probably separate the python scripts so that other platforms that can't build python (openbsd was mentioned I think) can build this |
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Aug 17, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 335458 run on x86_64-linux 1
2 packages marked as broken and skipped:
- lixStatic
- lixStatic.dev
2 packages built:
- nixStatic
- nixStatic.dev
Contributor
|
Agree with @rhelmot as a follow-on. |
This was referenced Aug 18, 2024
|
|
||
| # bin/psl-make-dafsa brings a large runtime closure through python3 | ||
| outputs = [ "bin" "out" "dev" ]; | ||
| outputs = lib.optional (!stdenv.hostPlatform.isStatic) "bin" ++ [ "out" "dev" ]; |
Member
There was a problem hiding this comment.
This is not great as the default output for static is now a different one.
Contributor
There was a problem hiding this comment.
Yes, but this way avoids rebuilds. Send a PR for the right change, as you see it?
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot build python statically, so we cannot have it as a runtime dependency
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.