vunit: init at 4.7.0 #336227
Open
vunit: init at 4.7.0 #336227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleightcap
commented
Aug 21, 2024
jleightcap
force-pushed
the
jl/vunit-4.7.0
branch
from
3c8eb79 to
448a438
Compare
ofborg
bot
added
8.has: package (new)
natsukium
requested changes
Aug 22, 2024
|
This is a python library, so please change the commit message to
|
Signed-off-by: Jack Leightcap <[email protected]> Co-authored-by: OTABI Tomoya <[email protected]>
jleightcap
force-pushed
the
jl/vunit-4.7.0
branch
from
5d66a6f to
72a4e51
Compare
|
thanks for the review and references @natsukium, believe i've addressed the feedback |
| hash = "sha256-ol+5kbq9LqhRlm4NvcX02PZJqz5lDjASmDsp/V0Y8i0="; | ||
| }; | ||
|
|
||
| patches = [ ./setuptools-relax-deps.patch ]; |
There was a problem hiding this comment.
Suggested change
| patches = [ ./setuptools-relax-deps.patch ]; | |
| pythonRelaxDeps = [ | |
| "setuptools" | |
| "setuptools_scm" | |
| ]; |
Should also work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jack Leightcap [email protected]
Description of changes
revive and complete #233474, packaging of popular HDL test suite
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.