python310Packages.vunit: init at 4.7.0 #233474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleightcap
changed the title
ofborg
bot
added
8.has: package (new)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2770 |
pbsds
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Good work!
This folder strikes me as not needed: lib/python3.10/site-packages/vunit/vhdl/JSON-for-VHDL/tests
The reason its included is likely here, and its intent seem to be to not distribute them? If you opt not to remove the tests folder:
- This file seems to require docker:
lib/python3.10/site-packages/vunit/vhdl/JSON-for-VHDL/tests/run.sh - This file seems to require GHDL:
lib/python3.11/site-packages/vunit/vhdl/JSON-for-VHDL/tests/ghdl/Boards2.sh
Result of nixpkgs-review pr 233474 run on x86_64-linux 1
4 packages built:
- python310Packages.vunit
- python310Packages.vunit.dist
- python311Packages.vunit
- python311Packages.vunit.dist
|
|
||
| disabledTestPaths = [ | ||
| "tests/lint" | ||
| "tests/acceptance" |
There was a problem hiding this comment.
Please add a comment defending why this is disabled.
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "vunit"; |
There was a problem hiding this comment.
There seems to be a naming conflict with vunit on pypi
Suggested change
| pname = "vunit"; | |
| pname = "vunit-hdl"; |
| @@ -12795,6 +12795,8 @@ self: super: with self; { | |||
|
|
|||
| vulture = callPackage ../development/python-modules/vulture { }; | |||
|
|
|||
| vunit = callPackage ../development/python-modules/vunit { }; | |||
There was a problem hiding this comment.
Suggested change
| vunit = callPackage ../development/python-modules/vunit { }; | |
| vunit-hdl = callPackage ../development/python-modules/vunit-hdl { }; |
https://vunit.github.io/index.html VUnit: a test framework for HDL Signed-off-by: Jack Leightcap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)