ladybird: 0-unstable-2024-07-11 -> 0-unstable-2024-08-12

[fgaz]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[qbit]

Builds fine but doesn't seem to load any pages:

VERIFICATION FAILED: m_default_font at /build/source/Ladybird/FontPlugin.cpp:45
/nix/store/yk44cnbs3gpa5hpaxml3gbw2jjr04knh-ladybird-0-unstable-2024-08-12/libexec/../lib/liblagom-ak.so.0(ak_verification_failed+0x83) [0x7fd510845633]
/nix/store/yk44cnbs3gpa5hpaxml3gbw2jjr04knh-ladybird-0-unstable-2024-08-12/libexec/WebContent() [0x50a0b8]
/nix/store/yk44cnbs3gpa5hpaxml3gbw2jjr04knh-ladybird-0-unstable-2024-08-12/libexec/WebContent() [0x43c96c]
/nix/store/yk44cnbs3gpa5hpaxml3gbw2jjr04knh-ladybird-0-unstable-2024-08-12/libexec/WebContent(main+0xf2) [0x42bc32]
/nix/store/0wydilnf1c9vznywsvxqnaing4wraaxp-glibc-2.39-52/lib/libc.so.6(+0x2a14e) [0x7fd51023314e]
/nix/store/0wydilnf1c9vznywsvxqnaing4wraaxp-glibc-2.39-52/lib/libc.so.6(__libc_start_main+0x89) [0x7fd510233209]
/nix/store/yk44cnbs3gpa5hpaxml3gbw2jjr04knh-ladybird-0-unstable-2024-08-12/libexec/WebContent() [0x42bd65]

[qbit]

Result of nixpkgs-review pr 334149 run on x86_64-linux 1

2 packages built:

• ladybird
• skia

[fgaz]

Builds fine but doesn't seem to load any pages:

It works for me. Are you on NixOS, and if so did you enable the ladybird option?

[qbit]

Builds fine but doesn't seem to load any pages:

It works for me. Are you on NixOS, and if so did you enable the ladybird option?

ugh. right. I have been here before :P I had it disabled because of #331105 .

It's pretty frustrating that you need to enable the option to make it work.

[fgaz]

It's pretty frustrating that you need to enable the option to make it work.

It's a common complaint... a lot of packages are like that but there is no way to inform the user about it

[YoshiRulz]

A comment in the expression would be a good start...
For future humans, the option in question is fonts.fontDir.enable.