Skip to content

Comments

ladybird: fix compilation by adding no longer propagated libraries#331105

Merged
fgaz merged 1 commit intoNixOS:masterfrom
SuperSandro2000:ladybird
Aug 7, 2024
Merged

ladybird: fix compilation by adding no longer propagated libraries#331105
fgaz merged 1 commit intoNixOS:masterfrom
SuperSandro2000:ladybird

Conversation

@SuperSandro2000
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 requested a review from K900 July 30, 2024 15:38
@ofborg ofborg bot requested a review from fgaz July 30, 2024 18:44
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 30, 2024
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fgaz
Copy link
Member

fgaz commented Aug 1, 2024

@SuperSandro2000 any reason why this is still a draft? Can I undraft and merge?

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 331105 run on x86_64-linux 1

1 package built:
  • ladybird

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browser seems to work using these changes

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 any reason why this is still a draft? Can I undraft and merge?

There is already a fix on the way on staging which fixes the underlying issue and all other similar changes for reverted.

@fgaz fgaz mentioned this pull request Aug 4, 2024
12 tasks
@fgaz
Copy link
Member

fgaz commented Aug 4, 2024

There is already a fix on the way on staging which fixes the underlying issue and all other similar changes for reverted.

Then shouldn't we merge this in the meantime? Staging cycles take quite a while. What's the relevant staging pr by the way? I can't find it

@fgaz fgaz marked this pull request as ready for review August 6, 2024 08:42
@fgaz
Copy link
Member

fgaz commented Aug 6, 2024

I'll merge in 24 hours

@SuperSandro2000
Copy link
Member Author

af6f430
0bfa3d0
#330211

@fgaz
Copy link
Member

fgaz commented Aug 6, 2024

#330211

Yeah that looks like it will potentially take a while. I say let's merge. I subscribed to 330211 on @nixpkgs-bot:maralorn.de so I can revert later.

@fgaz fgaz merged commit 757c942 into NixOS:master Aug 7, 2024
@SuperSandro2000 SuperSandro2000 deleted the ladybird branch August 8, 2024 10:11
@SuperSandro2000
Copy link
Member Author

I've pushed a revert to #332764

@fgaz
Copy link
Member

fgaz commented Aug 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants