ladybird: fix compilation by adding no longer propagated libraries#331105
ladybird: fix compilation by adding no longer propagated libraries#331105fgaz merged 1 commit intoNixOS:masterfrom
Conversation
|
@SuperSandro2000 any reason why this is still a draft? Can I undraft and merge? |
|
Result of 1 package built:
|
Scrumplex
left a comment
There was a problem hiding this comment.
The browser seems to work using these changes
There is already a fix on the way on staging which fixes the underlying issue and all other similar changes for reverted. |
Then shouldn't we merge this in the meantime? Staging cycles take quite a while. What's the relevant staging pr by the way? I can't find it |
|
I'll merge in 24 hours |
|
Yeah that looks like it will potentially take a while. I say let's merge. I subscribed to 330211 on @nixpkgs-bot:maralorn.de so I can revert later. |
|
I've pushed a revert to #332764 |
|
Thanks! |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.