Skip to content

Comments

compressDrv: get rid of unneeded extra params#332558

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
motiejus:compressDrv
Aug 5, 2024
Merged

compressDrv: get rid of unneeded extra params#332558
philiptaron merged 1 commit intoNixOS:masterfrom
motiejus:compressDrv

Conversation

@motiejus
Copy link
Contributor

@motiejus motiejus commented Aug 5, 2024

This is a leftover from the original versions of #292324. Reduces the API surface to not accept accidental arguments.

Things done

  • Built on platform(s)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This is a leftover from the original versions of NixOS#292324. Reduces the
API surface to not accept accidental arguments.
@motiejus motiejus marked this pull request as ready for review August 5, 2024 20:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 5, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good.

@philiptaron philiptaron merged commit fcefb0a into NixOS:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants