Doc: pkgs{compressDrv,compressDrvWeb} improve clarity#332466
Doc: pkgs{compressDrv,compressDrvWeb} improve clarity#332466philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
|
@motiejus Somwething i missed in the initial pr: Why do you need It is not possible to access the 'rest' arguments, and they are not forwarded to anything. Thus calling the function, with superfluous arguments will not result in an error. |
017fa7f to
475e245
Compare
475e245 to
f44ca26
Compare
f44ca26 to
782c1ea
Compare
|
This looks great, but I can only judge on the surface. Is there a simple-ish way to generate something like https://noogle.dev/f/pkgs/compressDrv locally to review rendered changes?
This is a left-over from previous PR incarnations and can be removed. You can do it here (AFAIK), or I can do this once this PR is merged -- I let's avoid conflicts either way. |
No unfortunately Not. Usually you would just build the Manual. But this doesnt appear in the Manual yet. Rendering this into the Manual is a Goal but a little complex, since we want a generic solution. You could build noogle yourself though. This will Take a while If you do it the First time. nix build GitHub:nix-community/noogle#ui --override-input nixpkgs-master {your url} |
|
This is perfect!
Any flags I am missing? |
|
Github needs to be lowercase. Got autocorrected in my Phone 😅
This should do (you can also replace |
|
I'm getting Problem on master?! |
Uh, shouldn't it was build from github ci 8 hrs ago. Are you building on darwin? Otherwise it seems some random npm dependency has changed the nar hash / integrity... which maybe ci doesnt experience, since it has nix-community binary cache ... I'll update the npm lockfile real quick |
|
Yep. Seems npm registry behavior changed. It'll be fixed anytime (minutes). We learn that registry sucks, and sometimes dependencies randomly change their hash .... |
|
This seems to build for this PR: Both http://localhost:8000/f/pkgs/compressDrvWeb and http://localhost:8000/f/pkgs/compressDrv look great. Thanks! |
| ::: | ||
| */ | ||
| drv: | ||
| { formats, compressors, ... }: |
There was a problem hiding this comment.
perhaps
| { formats, compressors, ... }: | |
| { formats, compressors }: |
while at it?
There was a problem hiding this comment.
Scratch that, there is one more place that needs, I will make a PR myself.
Description of changes
cc: @motiejus @Ma27
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.