Skip to content

python312Packages.textual: 0.72.0 -> 0.75.0#332289

Merged
drupol merged 1 commit intoNixOS:masterfrom
greg-hellings:textual-0.75.0
Aug 5, 2024
Merged

python312Packages.textual: 0.72.0 -> 0.75.0#332289
drupol merged 1 commit intoNixOS:masterfrom
greg-hellings:textual-0.75.0

Conversation

@greg-hellings
Copy link
Contributor

@greg-hellings greg-hellings commented Aug 4, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 4, 2024
@fabaff

This comment was marked as outdated.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 4, 2024
@ofborg ofborg bot requested a review from joelkoen August 4, 2024 18:16
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 4, 2024
@greg-hellings
Copy link
Contributor Author

Result of nixpkgs-review pr 332289 run on x86_64-linux 1
8 packages failed to build:
38 packages built:

Those 8 failures are not a result of this change, but rather of this PR.

I have already created a separate PR to address the graphrag failure and another to address the browsr failure.

textual-paint uses an internally pinned version of textual as well, pinned to an antique version, in order to satisfy its upstream requirements.txt pins. Therefore, this change does not impact it, either.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass the file through nixfmt-rfc-style

@greg-hellings
Copy link
Contributor Author

Please pass the file through nixfmt-rfc-style

I have. No change.

@drupol drupol merged commit feff2a4 into NixOS:master Aug 5, 2024
@natsukium
Copy link
Member

Please also check the diff.
It is obvious that the hash has not been updated and the change in optional-dependencies is inappropriate without explanation.

@drupol
Copy link
Contributor

drupol commented Aug 7, 2024

My mistake on this. I did this review on the phone and I should pay more attention. Sorry for the trouble.

@natsukium
Copy link
Member

Never mind. Thanks for all your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants