Skip to content

sieve: init at 0.6.1-unstable-2025-01-06#331070

Closed
fugidev wants to merge 1 commit intoNixOS:masterfrom
fugidev:sieve-app
Closed

sieve: init at 0.6.1-unstable-2025-01-06#331070
fugidev wants to merge 1 commit intoNixOS:masterfrom
fugidev:sieve-app

Conversation

@fugidev
Copy link
Member

@fugidev fugidev commented Jul 30, 2024

Description of changes

Adds Sieve, an Electron-based sieve script editor, for Linux and Darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 30, 2024
@KiaraGrouwstra
Copy link
Contributor

Result of nixpkgs-review pr 331070 run on x86_64-linux 1

1 package built:
  • sieve

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2099

@fugidev
Copy link
Member Author

fugidev commented Jan 6, 2025

Thanks for the review @eljamm! I've applied your requested changes, updated to the latest upstream commit and rebased onto master. I'll squash after testing on aarch64-linux and aarch64-darwin.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 6, 2025
@fugidev fugidev changed the title sieve: init at 0.6.1-unstable-2024-07-25 sieve: init at 0.6.1-unstable-2025-01-06 Jan 6, 2025
@eljamm
Copy link
Contributor

eljamm commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 331070


x86_64-linux

✅ 1 package built:
  • sieve

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the program as I don't know how to use it, but I trust that you did, so this looks good to me. Thanks a lot for your contribution!

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 6, 2025
@h7x4
Copy link
Member

h7x4 commented Feb 25, 2025

It seems this got added in #337931. It looks like there's quite a lot of stuff here that could be added to the existing package if you'd like. It might be better to open a new PR.

@fugidev
Copy link
Member Author

fugidev commented Feb 26, 2025

Thanks for letting me know. I'll be honest, it's quite disheartening to see a duplicate PR get merged so quickly, with nobody having checked if someone else had already made the effort to create one. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants