sieve: init at 0.6.1-unstable-2025-01-06#331070
Conversation
|
Result of 1 package built:
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2099 |
|
Thanks for the review @eljamm! I've applied your requested changes, updated to the latest upstream commit and rebased onto master. I'll squash after testing on aarch64-linux and aarch64-darwin. |
|
eljamm
left a comment
There was a problem hiding this comment.
I haven't tested the program as I don't know how to use it, but I trust that you did, so this looks good to me. Thanks a lot for your contribution!
|
It seems this got added in #337931. It looks like there's quite a lot of stuff here that could be added to the existing package if you'd like. It might be better to open a new PR. |
|
Thanks for letting me know. I'll be honest, it's quite disheartening to see a duplicate PR get merged so quickly, with nobody having checked if someone else had already made the effort to create one. :/ |
Description of changes
Adds Sieve, an Electron-based sieve script editor, for Linux and Darwin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.