ghc: bootstrap 9.8 from bindist again on Darwin#330560
Merged
maralorn merged 2 commits intoNixOS:masterfrom Jul 30, 2024
Merged
ghc: bootstrap 9.8 from bindist again on Darwin#330560maralorn merged 2 commits intoNixOS:masterfrom
maralorn merged 2 commits intoNixOS:masterfrom
Conversation
reckenrode
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
This was referenced Jul 28, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
The bindist defaults to enabling `ar -L` if it detects a compatible `ar`. Suppress this behavior by overriding the setting. This allows the bindist to be used to bootstrap GHC 9.8.
…lt 9.6" This reverts commit ccc08ba.
reckenrode
force-pushed
the
ghc-9.6.3-fixes
branch
from
46f201d to
ac9122d
Compare
Contributor
Author
|
I fixed the commit reference in the reverted commit. Thanks @vcunat for retargeting this to master after staging-next was merged. @sternenseemann Pinging you since you worked on the previous solution, and this is Haskell-related. |
maralorn
approved these changes
Jul 28, 2024
Member
maralorn
left a comment
maralorn
left a comment
There was a problem hiding this comment.
I don’t feel particularly firm with the details, but I like this.
Member
|
Thank you |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Split off from #330559. Targeting staging-next because the required version of ld64 is currently only on staging-next.
The issue was
ar -Lagain. When I tried building GHC 9.8 without the fix, the build failed at Shake, but the error was different on staging-next with ld64 951.9.After extracting the object from the file and inspecting it, I found that
LowLevel.owas another archive. Static archives inside static archives are not supported by ld64. Fortunately, it’s possible to override GHC’s settings to suppress usingar -L, which allowed me to switch the bootstrap back to the bindist.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.