Skip to content

haskell.compiler.ghc8107Binary: fix build on staging-next#330559

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
reckenrode:ghc-bindist-fixes
Jul 28, 2024
Merged

haskell.compiler.ghc8107Binary: fix build on staging-next#330559
vcunat merged 1 commit intoNixOS:staging-nextfrom
reckenrode:ghc-bindist-fixes

Conversation

@reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Jul 28, 2024

Description of changes

Fixes build failures on staging-next #328673.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jul 28, 2024
…4-darwin

Because the binaries in the bindist lack the linker-signed flag in their signatures, `install_name_tool` will invalidate them when it processes them. Repair the signatures using `rcodesign`, which can also set the linker-signed flag when it replaces the signatures. Having the flag present causes future invocations of `install_name_tool` and `strip` on them to update the signatures.
@reckenrode reckenrode changed the title haskell.compiler.{ghc8107,ghc924,ghc963}Binary: fix build on staging-next haskell.compiler.ghc8107Binary: fix build on staging-next Jul 28, 2024
@reckenrode
Copy link
Contributor Author

I moved the GHC 9.8 bootstrap fix to #330560.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 28, 2024
@vcunat vcunat merged commit 9fe04b5 into NixOS:staging-next Jul 28, 2024
@sternenseemann
Copy link
Member

Thanks!

@reckenrode reckenrode deleted the ghc-bindist-fixes branch July 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants