nixVersions.git: pre20240709_142e566a -> pre20240717_464e5925#327940
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 18, 2024
Merged
nixVersions.git: pre20240709_142e566a -> pre20240717_464e5925#327940roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
Aleksanaa
changed the title
ofborg
bot
added
10.rebuild-darwin: 1-10
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-15-nix-team-meeting-minutes-161/49228/2 |
Contributor
|
Result of 5 packages built:
|
marcusramberg
approved these changes
Jul 18, 2024
Contributor
marcusramberg
left a comment
marcusramberg
left a comment
There was a problem hiding this comment.
Tested the :doc stuff, looks really good :)
Member
|
Thanks for the bump and review! |
Member
Author
|
@emilazy could you check if this is also broken on x86_64-darwin? Related to NixOS/nix#11138 |
Member
|
I’m afraid it is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Mainly to be the first to taste doc-comments:
screenshot
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.