libmain: add missing header include#11138
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jul 19, 2024
Merged
Conversation
Member
|
Sorry about that. Really odd it would only affect one darwin arch! |
13 tasks
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the build for me on
x86_64-darwin. I have no idea how this passed CI (SDK version header differences?). Ifx86_64-darwinis meant to be a viable Nix platform I’d strongly recommend ensuring that CI continues to build it, as this is the second recent incident of a broken build only onx86_64-darwin. (Of course, using an Apple Silicon runner to build thex86_64-darwinversion through Rosetta is fine.)cc @Ericson2314 who might have introduced this by moving the plugin code around
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.