Skip to content

godot3-mono: fix scons override python3 argument#326478

Merged
K900 merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/scons-fix-eval
Jul 12, 2024
Merged

godot3-mono: fix scons override python3 argument#326478
K900 merged 1 commit intoNixOS:stagingfrom
doronbehar:pkg/scons-fix-eval

Conversation

@doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900
Copy link
Contributor

K900 commented Jul 12, 2024

Thanks!

@K900 K900 merged commit 1220adb into NixOS:staging Jul 12, 2024
@doronbehar
Copy link
Contributor Author

Not too fast? I wanted to see if CI is indeed completely green with this change... Let's hope it is.

@K900
Copy link
Contributor

K900 commented Jul 12, 2024

It's not going to finish anyway, it'll try to build an stdenv, and the eval checks need the base branch to also eval.

@doronbehar doronbehar deleted the pkg/scons-fix-eval branch October 30, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants