Skip to content

scons: update to 4.7.0, drop all the old versions#323822

Merged
K900 merged 3 commits intoNixOS:stagingfrom
K900:scons-4.7.0
Jul 2, 2024
Merged

scons: update to 4.7.0, drop all the old versions#323822
K900 merged 3 commits intoNixOS:stagingfrom
K900:scons-4.7.0

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Jul 1, 2024

Description of changes

This techinically removes the man pages, but that's probably fine?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jul 1, 2024
@ofborg ofborg bot requested review from AndersonTorres and cpages July 1, 2024 15:53
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 1, 2024
@AndersonTorres
Copy link
Member

Are the older versions not needed anymore? Yay!

@K900 K900 requested a review from AndersonTorres July 2, 2024 11:29
@mweinelt
Copy link
Member

mweinelt commented Jul 2, 2024

Same for openvino

@K900 K900 merged commit 8f41c75 into NixOS:staging Jul 2, 2024
@AndersonTorres
Copy link
Member

Next will be how to fix the dreadful lack of manpages

@doronbehar
Copy link
Contributor

Hmm I wonder how come CI was green. A quick git grep scons.override reveals a few more evaluations fixes missing...

@K900
Copy link
Contributor Author

K900 commented Jul 12, 2024

Those were probably merged into master later.

@K900
Copy link
Contributor Author

K900 commented Jul 12, 2024

I'll do another pass of these after the next staging cycle, probably.

@doronbehar
Copy link
Contributor

I already opened #326478 to help other PRs that target currently staging.

@K900 K900 deleted the scons-4.7.0 branch July 27, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants