Skip to content

nv-codec-headers: recreate under by-name (try 2)#325517

Merged
thiagokokada merged 2 commits intoNixOS:masterfrom
atorres1985-contrib:nv-codec-headers-master
Jul 22, 2024
Merged

nv-codec-headers: recreate under by-name (try 2)#325517
thiagokokada merged 2 commits intoNixOS:masterfrom
atorres1985-contrib:nv-codec-headers-master

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jul 8, 2024

Description of changes

Retakes #324199

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 8, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review July 12, 2024 13:56
@AndersonTorres AndersonTorres mentioned this pull request Jul 18, 2024
Closed
13 tasks
@AndersonTorres
Revert "Merge pull request #325242 from flokli/revert-nv-codec-headers"
e8afe8d 
This reverts commit 4685e6f, reversing
changes made to f99e3f2.

Let's undo the undo first
@AndersonTorres
nv-codec-headers: hide parameter sources
c7316ef 
In order to avoid clash with external overlays that use the name `source`.
thiagokokada
thiagokokada reviewed Jul 21, 2024
View reviewed changes
thiagokokada
thiagokokada approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thiagokokada thiagokokada merged commit e2ee34b into NixOS:master Jul 22, 2024
@AndersonTorres AndersonTorres mentioned this pull request Jul 24, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndersonTorres @thiagokokada