nv-codec-headers: recreate under by-name#324199
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jul 6, 2024
atorres1985-contrib:nv-codec-headers-master
Merged
nv-codec-headers: recreate under by-name#324199Aleksanaa merged 1 commit intoNixOS:masterfrom atorres1985-contrib:nv-codec-headers-master
Aleksanaa merged 1 commit intoNixOS:masterfrom
atorres1985-contrib:nv-codec-headers-master
Conversation
Member
Author
|
I will split handbrake in its own PR: #324418 |
Member
|
Could you split migration and format in two commits to have a good log? |
Member
Author
|
Formatting? This is a whole new derivation written basically from scratch that does the same as the previous one. Any "intermediate steps" would be broken by definition. |
Member
|
Then I have to say that your commit message is a bit misleading 😅 |
Member
Author
|
I will reformulate as soon as possible. |
This commit merely deletes the old directory, creates the new files in the new location and rewrite the overrides. The whole change needs to be made "atomically", since it is not pratical to create intermediate steps that compile cleanly.
Member
Author
|
@Aleksanaa done. |
Aleksanaa
approved these changes
Jul 6, 2024
13 tasks
Member
|
It looks like this broke eval: |
flokli
added a commit
to flokli/nixpkgs
that referenced
this pull request
Jul 7, 2024
This reverts commit 01f7c8a. It broke NixOS config evaluation, as in NixOS#324199 (comment).
13 tasks
Member
|
Revert in #325242. |
Member
|
I don't quite get it: Looks normal? |
Member
|
This PR only drops |
Member
Author
|
Oh boi, just when I was updating nvch 12... |
13 tasks
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.