Skip to content

python312Packages.makefun, python312Packages.twisted: disable failing test#320647

Merged
vcunat merged 2 commits intoNixOS:staging-next-24.05from
mweinelt:24.11/python3.12.4-fixes-cont
Jun 18, 2024
Merged

python312Packages.makefun, python312Packages.twisted: disable failing test#320647
vcunat merged 2 commits intoNixOS:staging-next-24.05from
mweinelt:24.11/python3.12.4-fixes-cont

Conversation

@mweinelt
Copy link
Member

Description of changes

#317935 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

mweinelt added 2 commits June 18, 2024 02:13
These started failing with 3.12.4.

(cherry picked from commit 3215c60)
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 18, 2024
@ofborg ofborg bot requested a review from veehaitch June 18, 2024 00:57
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 18, 2024
@mweinelt mweinelt changed the title python312Packages.makefun: disable failing test python312Packages.makefun, python312Packages.twisted: disable failing test Jun 18, 2024
@vcunat vcunat merged commit d66710a into NixOS:staging-next-24.05 Jun 18, 2024
@mweinelt mweinelt deleted the 24.11/python3.12.4-fixes-cont branch June 18, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants