You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
I think the 24.05 backport was merged too soon. We'd now be getting this in nixos-24.05 before nixos-unstable, but that's not great, as experience shows that even patch-level bumps of python break things commonly. (fortunately 3.12 is not the default python version at least)
The first regression we see now is sphinx (checked locally that the python bump itself triggered that).
Okay, I think I've got fixes for all three packages ready. Ideally we'd manage them in staging first, but now that we are here, we might as well deal with them.
I suppose, if we seem to have enough manpower to fix these, we can try keeping it in this staging-next-24.05 iteration. The advantage of stable staging is that there's typically much less noise than in staging-next.
Found issues for makefun and twisted, ended up disabling those tests. Creating an issue for mashumaro, since I assume they fixed the issue in one version, then introduced other issues, because they were testing with Python 3.12.3, not 3.12.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.topic: pythonPython is a high-level, general-purpose programming language.10.rebuild-darwin: 501+This PR causes many rebuilds on Darwin and should normally target the staging branches.10.rebuild-darwin: 5001+This PR causes many rebuilds on Darwin and must target the staging branches.10.rebuild-linux: 501+This PR causes many rebuilds on Linux and should normally target the staging branches.10.rebuild-linux: 5001+This PR causes many rebuilds on Linux and must target the staging branches.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 501+
https://docs.python.org/release/3.12.4/whatsnew/changelog.html
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.