Skip to content

Comments

[24.05] Assorted haskellPackages fixes#319648

Merged
maralorn merged 3 commits intoNixOS:release-24.05from
rnhmjoj:pr-haskell-fixes-back
Jun 14, 2024
Merged

[24.05] Assorted haskellPackages fixes#319648
maralorn merged 3 commits intoNixOS:release-24.05from
rnhmjoj:pr-haskell-fixes-back

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 13, 2024

Description of changes

Backport of #317451

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 13, 2024
@rnhmjoj rnhmjoj changed the title Assorted haskellPackages fixes [24.05] Assorted haskellPackages fixes Jun 13, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 13, 2024
@maralorn
Copy link
Member

Can you please create the commits according to this section? https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-backport-pull-requests

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 13, 2024

I didn't use cherry-pick -x because the patch are not identical, but ok.

@maralorn
Copy link
Member

Ah, okay. I didn’t spot the difference.

@rnhmjoj rnhmjoj force-pushed the pr-haskell-fixes-back branch from cadc5cd to e4fc2a0 Compare June 14, 2024 15:08
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 14, 2024

Ok, I added the references to the original commits.

@maralorn maralorn merged commit 2a3a9b7 into NixOS:release-24.05 Jun 14, 2024
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 14, 2024

Thank you!

@rnhmjoj rnhmjoj deleted the pr-haskell-fixes-back branch November 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants