Skip to content

Comments

Assorted haskellPackages fixes#317451

Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
rnhmjoj:pr-haskell-fixes
Jun 12, 2024
Merged

Assorted haskellPackages fixes#317451
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
rnhmjoj:pr-haskell-fixes

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 5, 2024

Description of changes

Fixing the usual bunch of semi-unmtaintained packages.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 5, 2024
@rnhmjoj rnhmjoj changed the title Pr haskell fixes Assorted haskellPackages fixes Jun 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 5, 2024
@rnhmjoj rnhmjoj force-pushed the pr-haskell-fixes branch from 71376b9 to 4636757 Compare June 6, 2024 10:16
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 10, 2024

friendly ping

@maralorn
Copy link
Member

Thank you

@maralorn maralorn merged commit e99a168 into NixOS:haskell-updates Jun 12, 2024
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 12, 2024

@maralorn is there a specific workflow for backporting to stable or I can just cherry-pick these commits and remove the broken=true from hackage-packages.nix?

@maralorn
Copy link
Member

Ah, well. Please follow the general rules for creating backports. (i.e. use the right cherry-pick command)
When you edit the hackage-packages.nix make sure to also remove the hydraPlatforms = none line.

@rnhmjoj rnhmjoj deleted the pr-haskell-fixes branch November 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants