Skip to content

segger-jlink: 796b -> 796k, segger-jlink-headless: init, plus misc changes#319342

Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
h7x4:pkgs-segger-jlink-misc-fixups
Jul 4, 2024
Merged

segger-jlink: 796b -> 796k, segger-jlink-headless: init, plus misc changes#319342
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
h7x4:pkgs-segger-jlink-misc-fixups

Conversation

@h7x4
Copy link
Member

@h7x4 h7x4 commented Jun 12, 2024

Description of changes

Miscellaneous fixes to segger-jlink. I have added a headless variant of the package that excludes the qt4 bundle, removing the need for adding it to the list of insecure packages. The headless variant is exposed as a toplevel attribute with the -headless suffix.

As for other changes, I've added a changelog link, added myself to maintainers, added an update script and bumped the package version

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@h7x4 h7x4 requested a review from StarGate01 June 12, 2024 15:51
@h7x4 h7x4 force-pushed the pkgs-segger-jlink-misc-fixups branch from ec0e6d7 to 053ded0 Compare June 12, 2024 15:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 12, 2024
@h7x4 h7x4 mentioned this pull request Jun 18, 2024
13 tasks
@StarGate01
Copy link
Member

StarGate01 commented Jun 18, 2024

Does nrfconnect work with the new segger-jlink-headless as a dependency? Then I suggest to use that, see https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/nr/nrfconnect/package.nix#L23 . After this PR is tested and merged, I will also update #214195 .

@h7x4
Copy link
Member Author

h7x4 commented Jun 18, 2024

Does nrfconnect work with the new segger-jlink-headless as a dependency?

I'm not entirely sure tbh, but I think so. It's a suite of tools made for the nordicsemi boards, and while they need jlink to probe the devkits, it would be weird if they embedded usage of segger's gui tools within their own.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4189

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well made

@SuperSandro2000 SuperSandro2000 merged commit b8a6b3f into NixOS:master Jul 4, 2024
@h7x4 h7x4 deleted the pkgs-segger-jlink-misc-fixups branch October 31, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants