segger-jlink: 796b -> 796k, segger-jlink-headless: init, plus misc changes#319342
Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom Jul 4, 2024
Merged
segger-jlink: 796b -> 796k, segger-jlink-headless: init, plus misc changes#319342SuperSandro2000 merged 6 commits intoNixOS:masterfrom
SuperSandro2000 merged 6 commits intoNixOS:masterfrom
Conversation
ec0e6d7 to
053ded0
Compare
Member
|
Does |
Member
Author
I'm not entirely sure tbh, but I think so. It's a suite of tools made for the nordicsemi boards, and while they need jlink to probe the devkits, it would be weird if they embedded usage of segger's gui tools within their own. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4189 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Miscellaneous fixes to
segger-jlink. I have added a headless variant of the package that excludes the qt4 bundle, removing the need for adding it to the list of insecure packages. The headless variant is exposed as a toplevel attribute with the-headlesssuffix.As for other changes, I've added a changelog link, added myself to maintainers, added an update script and bumped the package version
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.