Conversation
d6ec6ba to
538619d
Compare
538619d to
fdaf909
Compare
af37caf to
fb3b0f0
Compare
17094a5 to
90ac35f
Compare
490ba94 to
eebe8eb
Compare
29d6407 to
5666700
Compare
5666700 to
ef415f9
Compare
ef415f9 to
1d5e36e
Compare
|
Now that #255185 has been merged, I have rebased this PR to only contain the changes for the systemview package. |
1d5e36e to
7a868b3
Compare
7a868b3 to
1ae55ed
Compare
1ae55ed to
f3652b8
Compare
f3652b8 to
2b8e065
Compare
There was a problem hiding this comment.
We don't accept more qt4 package and have been trying to remove or update them.
There was a problem hiding this comment.
The package has a hard dependency on QT4. Without QT4, it does not run. Please review the discussion on QT4 at #255185 , SEGGER is unwilling to upgrade the QT version.
There was a problem hiding this comment.
There was a problem hiding this comment.
So to introduce a proprietary software with outdated dependencies... why? It's not like it was ever there and we need to remove it.
There was a problem hiding this comment.
I understand your concerns, but as @h7x4 pointed out, this package required the user to explicitly understand and allow (1) the license and (2) the outdated libs. Other packages and systems are unaffected by this package, i.e. if you do not use it you are unaffected.
SystemView is a widely used industry-standard embedded debugging suite, see https://www.segger.com/products/development-tools/systemview/ . It would be nice for NixOS to evolve from a project for ambitions hobbyists into a system which supports real-world software.
If I could, I would just provide this package out-of tree, similar to how e.g. Arch (https://aur.archlinux.org/packages/jlink-systemview) does it, but this does not work for nixpkgs. I do not have the bandwidth to maintain an eternal fork for a simple package.
There was a problem hiding this comment.
There was a problem hiding this comment.
We might be able to, but the bundled QT libs may change in between releases. AFAIK only the libraries which are directly needed by the related package are included, which might not be enough for the other packages.
I have not verified this, but I am hesitant to de-duplicate these "independent" libs.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
2b8e065 to
8da6ceb
Compare
f05cb7c to
667ff5a
Compare
667ff5a to
eacb894
Compare
1f52b68 to
81b1064
Compare
|
Hi, sorry that this PR was dormant for a long time.
This is totally possible – since this is a leaf package that other packages don’t depend on, you can put up a repository containing just the additional packages that users can overlay on top of Nixpkgs. Flakes can help do this, and there are already a lot of third‐party repositories doing this (e.g. rust-overlay, nixos-cosmic, and even from before flakes were a thing the Nix User Repository). I would encourage you to do that since we removed Qt 4 two and a half years ago and really don’t want to accept new packages using Qt 4 or take up the burden of maintaining them; if anything, we’re trying to reduce out use of Qt 5 in anticipation of it going EOL next year. I think that #255185 should not have been accepted either, unfortunately, but it should be simple to provide these packages in your own repository without having to maintain a fork of Nixpkgs. Please let me know if you need any pointers on how to accomplish this. |
This is a proprietary package that depends on the vulnerability‐ridden Qt 4, and was removed along with Qt 4 in 2022. It was re‐added at the beginning of the year, but upstream is unwilling to upgrade their Qt version and as it is proprietary software we have no way to patch it on our end. I think that it would be best not to ship this in 24.11. While it’s clearly useful software, we made the deliberate decision to remove Qt 4 seven years after it reached end of life, and since this software is seemingly doomed to eternal `knownVulnerabilities` I think that it does not meet our standards for inclusion. This would be better maintained in a third‐party repository, as suggested by the maintainer in <NixOS#214195 (comment)>. This reverts commit d5fd263.
|
@emilazy Thank you for your suggestion. Although I don't agree on the removal of the tools from nixpkgs (yet), I would like to explore the option of providing them via a flake. Do you have some resources I could use as a template? |
|
The simplest thing would be a flake that just provides an overlay: {
outputs = { self }: {
overlays.default = final: prev: {
segger-jlink = final.callPackage ./pkgs/segger-jlink { };
nrfconnect = final.callPackage ./pkgs/nrfconnect { };
# …
};
};
}Users could include it in their configuration with {
inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
};
outputs = { self, nixpkgs }: {
packages = let
systems = [
"x86_64-linux"
"i686-linux"
"aarch64-linux"
"armv7l-linux"
];
in nixpkgs.lib.genAttrs systems (system:
nixpkgs.legacyPackages.${system}.extend self.overlays.default
);
overlays.default = …; # same as before
};
} |
81b1064 to
dccd243
Compare
ebff7ed to
0f3fa18
Compare
0f3fa18 to
de542f3
Compare
|
Bump, now we started removing qt5 |
Description of changes
This PR adds the SEGGER SystemView debugging utility. It depends on the SEGGER J-Link libraries which are tracked in PR #255185 .
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes