Skip to content

buildMavenPackage: add doCheck support#316765

Merged
superherointj merged 11 commits intoNixOS:masterfrom
superherointj:maven-add-doCheck-support
Jun 4, 2024
Merged

buildMavenPackage: add doCheck support#316765
superherointj merged 11 commits intoNixOS:masterfrom
superherointj:maven-add-doCheck-support

Conversation

@superherointj
Copy link
Contributor

  • buildMavenPackage: add doCheck support
  • normalize doCheck: h2, kotlin-interactive-shell, sonarlint-ls, ns-usbloader, openrefine, commafeed, java-language-server, forge-mtg, mariadb-connector-java, s3proxy

@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 3, 2024

  1. I am dealing with these files too: Maven: refactor #316764
  2. cko, the maintainer of Maven, is on the retirements list: [Tracking issue] Silent retirement of maintainers #290642

What do you think about merge both PRs?

@superherointj
Copy link
Contributor Author

superherointj commented Jun 3, 2024

  1. I am dealing with these files too: Maven: refactor #316764

What a coincidence of timing. This was on my queue for quite some time.

What do you think about merge both PRs?

By merge, unify as one?
Wouldn't be simpler to just merge this first. (Because it's simple and straightforward. Only one file conflicts minimally.)
And then I review your PR.

@AndersonTorres
Copy link
Member

Nice. I will wait your PR, then.

@superherointj superherointj marked this pull request as draft June 3, 2024 00:29
@superherointj superherointj force-pushed the maven-add-doCheck-support branch from a95d7ce to 6ab6515 Compare June 3, 2024 00:35
@superherointj
Copy link
Contributor Author

superherointj commented Jun 3, 2024

Result of nixpkgs-review pr 316765 run on x86_64-linux 1

1 package failed to build:
  • jd-cli [Already failing in master, unrelated]
27 packages built:
  • apgdiff
  • bytecode-viewer
  • certificate-ripper
  • commafeed
  • cryptomator
  • digital
  • forge-mtg
  • gephi
  • global-platform-pro
  • h2
  • h2.doc
  • java-language-server
  • jugglinglab
  • kotlin-interactive-shell
  • ktfmt
  • lemminx
  • mariadb-connector-java
  • ns-usbloader
  • openrefine
  • quark-goldleaf
  • runelite
  • s3proxy
  • scenebuilder
  • schemaspy
  • slipstream
  • sonarlint-ls
  • tabula-java

@superherointj superherointj marked this pull request as ready for review June 3, 2024 00:49
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 3, 2024
@superherointj superherointj requested review from pluiedev, starsep and tricktron and removed request for pluiedev June 4, 2024 17:24
@superherointj superherointj merged commit 1993b60 into NixOS:master Jun 4, 2024
@superherointj superherointj deleted the maven-add-doCheck-support branch June 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants