Maven: refactor#316764
Merged
superherointj merged 4 commits intoNixOS:masterfrom Jun 9, 2024
atorres1985-contrib:maven-refactor
Merged
Maven: refactor#316764superherointj merged 4 commits intoNixOS:masterfrom atorres1985-contrib:maven-refactor
superherointj merged 4 commits intoNixOS:masterfrom
atorres1985-contrib:maven-refactor
Conversation
Member
Author
|
@infinisil since this has some potential to interact with RFC 140, and I am planning to disband build-support, I ask your opinion here. |
ofborg
bot
added
8.has: clean-up
And expose it via passthru
- align input set - remove jdk assertion - remove references to pname - get rid of nested with - meta.longDescription - meta.platforms
Member
Author
Contributor
|
I will get to it. I haven't forgotten. |
superherointj
approved these changes
Jun 9, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get rid of
build-support.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.