firefox-bin: 56.0.2 -> 57.0

[tokudan]

(cherry picked from commit a74fd1d)

Motivation for this change

Security updates in firefox 57 (only firefox-bin derivation)

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[matklad]

Works for me on 17.09, thanks @tokudan !

[Mic92]

@GrahamcOfBorg build firefox-bin

[GrahamcOfBorg]

Failure for system: x86_64-darwin

error: assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31663/pkgs/applications/networking/browsers/firefox-bin/default.nix:50:1

[GrahamcOfBorg]

Failure for system: x86_64-linux

error: Package ‘firefox-release-bin-unwrapped-57.0’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31663/pkgs/applications/networking/browsers/firefox-bin/default.nix:179 has an unfree license (‘unknown’), refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

[Mic92]

Why is firefox-bin unfree?

[vcunat]

@Mic92: there are some restrictions due to branding IIRC.

[andrewrk]

I thought those were lifted: https://www.pcworld.com/article/3036509/linux/iceweasel-will-be-renamed-firefox-as-relations-between-debian-and-mozilla-thaw.html

[vcunat]

AFAIK this is a bilateral agreement and not a general permission from Mozilla. (Besides the fact that this particular PR is about binary FF and not source-built one.) Still, some of our Mozillians might explain these things better...

[andrewrk]

I think it is in both of nixos and mozilla's best interest to make the firefox package(s) in nixos under a free license. We can probably work out some kind of deal.

[vcunat]

We're hijacking this thread a bit. IMHO Mozilla still generally insists on restricting usage of the branding, and that violates the most common definitions of "free" licenses, as you can't freely redistribute modified versions (unless Mozilla approves of the modifications).

I'm personally not motivated enough by mere branding to push this forward myself. Also /cc maintainer @garbas (who should know more about Mozilla, too).