Skip to content

Comments

firefox: 56.0.2 -> 57.0 [Security fixes]#31661

Merged
7c6f434c merged 5 commits intoNixOS:masterfrom
taku0:firefox-bin-57.0
Nov 14, 2017
Merged

firefox: 56.0.2 -> 57.0 [Security fixes]#31661
7c6f434c merged 5 commits intoNixOS:masterfrom
taku0:firefox-bin-57.0

Conversation

@taku0
Copy link
Contributor

@taku0 taku0 commented Nov 14, 2017

Motivation for this change
  • Various security fixes
  • A completely new browsing engine, designed to take full advantage of the processing power in modern devices
  • A redesigned interface with a clean, modern appearance, consistent visual elements, and optimizations for touch screens
  • Legacy extensions will no longer work.

https://www.mozilla.org/en-US/firefox/57.0/releasenotes/
https://www.mozilla.org/en-US/security/known-vulnerabilities/firefox/#firefox57

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

firefox-esr is not tested.


@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 14, 2017
@fpletz fpletz added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 14, 2017
@fpletz
Copy link
Member

fpletz commented Nov 14, 2017

Does this version of firefox depend on the nspr and nss updates? This could complicate backports.

@taku0
Copy link
Contributor Author

taku0 commented Nov 14, 2017

@fpletz Yes, Firefox always depends on the latest NSPR and NSS. The configure script checks the version.

@tokudan
Copy link
Contributor

tokudan commented Nov 14, 2017

I've added a pull request to backport firefox-bin to release-17.09 in #31663

@7c6f434c 7c6f434c merged commit cacd720 into NixOS:master Nov 14, 2017
@lheckemann
Copy link
Member

This changes the options used to build the ESR as well, though I don't really think it should…

@domenkozar
Copy link
Member

I've backported the source version as well.

@fpletz
Copy link
Member

fpletz commented Nov 16, 2017

@domenkozar It won't compile, though: #31706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants