Skip to content

jdk: misc cleanup#314380

Merged
thiagokokada merged 9 commits intoNixOS:masterfrom
Infinidoge:bump-openjdk-jdkjfx
May 25, 2024
Merged

jdk: misc cleanup#314380
thiagokokada merged 9 commits intoNixOS:masterfrom
Infinidoge:bump-openjdk-jdkjfx

Conversation

@Infinidoge
Copy link
Contributor

@Infinidoge Infinidoge commented May 24, 2024

Description of changes

Split from #286267

CCing @thiagokokada @philiptaron as previous reviewers

Bumps the JDK/JFX 21 versions to their respective latest versions, as well as miscellaneous cleanup of both

Rebased out version bump in favor of #313928, folded in #314384 to make this a cleanup PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This isn't used in any other packages, and the main version itself is
currently marked as insecure.
There isn't really a reason to keep it around in all-packages.

It can still be accessed under javaPackages.compilers.openjdk16-bootstrap
@Infinidoge Infinidoge force-pushed the bump-openjdk-jdkjfx branch from db70b18 to f29911a Compare May 24, 2024 21:09
@Infinidoge Infinidoge mentioned this pull request May 24, 2024
13 tasks
@Infinidoge Infinidoge changed the title open{jdk,jfx}: bump 21 and misc cleanup jdk: misc cleanup May 24, 2024
@Infinidoge Infinidoge force-pushed the bump-openjdk-jdkjfx branch from f29911a to ccbada9 Compare May 24, 2024 21:46
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label May 24, 2024
@ofborg ofborg bot requested a review from abbradar May 24, 2024 22:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 24, 2024
@thiagokokada thiagokokada merged commit fde6301 into NixOS:master May 25, 2024
@doronbehar doronbehar mentioned this pull request Jun 30, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants