Skip to content

openjdk21, openjfx21: update#313928

Merged
wegank merged 2 commits intoNixOS:stagingfrom
wegank:openjdk-bump-split-5
Jun 1, 2024
Merged

openjdk21, openjfx21: update#313928
wegank merged 2 commits intoNixOS:stagingfrom
wegank:openjdk-bump-split-5

Conversation

@wegank
Copy link
Member

@wegank wegank commented May 23, 2024

Description of changes

Split from #286267.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from abbradar and edwtjo May 23, 2024 09:41
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 23, 2024
@thiagokokada
Copy link
Contributor

Any reason for this to be marked as draft?

@wegank wegank marked this pull request as ready for review May 26, 2024 15:35
@wegank
Copy link
Member Author

wegank commented May 26, 2024

Any reason for this to be marked as draft?

I'm not sure if it can target master, although this PR's rebuilds are much faster than 17's on my machine.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should indeed target staging...

I've tested building and running ammonite (which is a binary), and building and running s3proxy (which is built with maven), both seemed fine.

Testing everything doesn't seem appropriate, but perhaps we should come up with a 'standard' set of tests we want to run when updating the default jdk?

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 29, 2024
@Tungsten842 Tungsten842 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 29, 2024
@wegank wegank changed the base branch from master to staging June 1, 2024 15:03
@ofborg ofborg bot requested a review from Infinidoge June 1, 2024 16:56
@wegank wegank merged commit 4ed4611 into NixOS:staging Jun 1, 2024
@wegank wegank deleted the openjdk-bump-split-5 branch June 1, 2024 20:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

Successfully created backport PR for staging-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants