haskellPackages.hercules-ci-*: update#312878
Closed
roberth wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
This is an ad hoc update ahead of haskell-updates because of a build issue introduced by NixOS#312433
roberth
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
Author
|
@ofborg build hci hercules-ci-agent cachix |
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
Ah, you are right hercules-ci-agent builds just fine on haskell-updates even though the cachix bump is included there. |
Member
|
Sounds good. |
maralorn
requested changes
May 19, 2024
Member
maralorn
left a comment
maralorn
left a comment
There was a problem hiding this comment.
Since hercules-ci is now fixed on master I suggest not doing this dance.
Member
Author
|
Hmm, branch-off is on Wednesday. |
Member
|
It would be my goal to get that into 24.05. If all fails, it'll just have to be in the first staging iteration for that release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is an ad hoc update ahead of haskell-updates because of a build issue introduced by #312433
I'll take care of any merge conflicts.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.